Semantic matching basics #4788 #4793
Open
+658
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d4vidi
requested changes
Jul 28, 2025
Collaborator
d4vidi
left a comment
d4vidi
left a comment
There was a problem hiding this comment.
- Definitely need to add some e2e tests coverage
- 2 big questions to answer before we can move fwd with impl and fixing stuff here
* moved semanticTypes.js to src/matchers/ * changed invoker from type(x) to semanticType(x) * re-indexed some of the classes with its matching semantic types (eg. added RCTTouchable...) * unit test updates
noomorph
requested changes
Aug 28, 2025
Collaborator
noomorph
left a comment
noomorph
left a comment
There was a problem hiding this comment.
Last but not least, the unit tests seem a bit weird at times.
I attribute this expect(...).not.toThrow() style to some existing precedents in the codebase, but still it won't hurt to think once again what we want actually to test there and whether we test everything that really matters there.
noomorph
reviewed
Oct 2, 2025
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this pull request, I have …