Examples pr#199
Open
ori-tirosh wants to merge 20 commits intomasterfrom
Open
Conversation
- Updated hero subtitle styling to include a text stroke effect (better for visibility). - Renamed performance-section to cube-section in HTML for clarity (previously both it and the section above it were called performance-section for some reason) - added conditions for Desktop & Mobile in the config - Added mobile-specific animations for: 1. the hero section: customEffect, called rotateGridEffectMobile, works as intended (no issues from what I can tell) 2. 1. the "performance" section: customEffect, called animateTunnelMobile, works as inteded when in mobile breakpoint (the animation itself still needs tweaking, but it works), but in desktop breakpoint, both the animateTunnel & animateTunnelMobile run simultaneously despite the conditions, I haven't been able to fix this yet - changed the trigger for the cube's effect "spongeExplode" (the key is called hitbox) in mobile to be viewEnter instead of hover, but the problem is (the same with animateTunnel) that, when in desktop, the mobile animation overrides the desktop animation, I haven't been able to fix this yet
- Updated navigation button styles for improved hover effects (removed blend mode, gave it outline, and inverted its color on hover). - Adjusted heading sizes and line heights for better readability across sections (aka typography fixes, leading, font size..etc) - Implemented mobile-specific animations for the spread section, including easing adjustments and keyframe effects. - Enhanced z-index management for spread cards in desktop view. (added media query for mobile) - fixed the animation of horizontal track (the website showcase), or rather fixed the sizing and with that I had to change the animation a bit for the mobile (I also added media query in CSS)
… snippet rendering - Included highlight.js CSS and JS for enhanced code presentation. - Updated modal and snippet rendering to apply syntax highlighting dynamically. - Adjusted CSS for pyramid wrapper and responsive design improvements. - made the gaps between effect example a bit smaller on mobile
- moved the mobile condition to inside the effect (instead of key&trigger level), this works apparantly, but I think it's a bug
- Added 'params' for entrance effects in the "Effects. Tailored to Your Vision" section to ensure they trigger only once on view entry. - in mobile: added bottom padding for performance section and cube section, so that the tunnel and cube don't get cropped at the bottom of the section
- Replaced the old grid update function with a new buildGrid function - Introduced lineStates and lineCache for managing grid line animations based on mouse movement. - Implemented pointerMoveEffect and gridWaveEffect for enhanced visual interactions. - Updated CSS for grid-line styling and responsiveness, adjusting height and background for better aesthetics. - Modified event listeners to utilize the new buildGrid function on window resize.
# Conflicts: # CLAUDE.md # CLAUDE.md~HEAD # assets/main.mjs # assets/modal.js # index.html
Refactored and fixed a lot of things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
added examples
Related Issue
Checklist
Screenshots / Demos
Additional Notes