Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [iPadOS 18] Disable the new UITabBarController view style in iPadOS 18 #7947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maheshwaripurvesh
Copy link

@maheshwaripurvesh maheshwaripurvesh commented Dec 15, 2024

Description

Since iPadOS 18, the Bottom Tab Bar on iPads is now positioned at the top of the screen, floating over the content, instead of at the bottom. This may be the feature by Apple in new version however creating poor user experience

Fix

  1. Check the ios18 and iPad variant
  2. If above condition statisfy, apply following

    .traitOverrides.horizontalSizeClass = UIUserInterfaceSizeClassUnspecified;

This will disable the new UITabBarController view style in iPadOS 18

References

Announcement: https://developer.apple.com/design/human-interface-guidelines/tab-bars#iPadOS

@maheshwaripurvesh maheshwaripurvesh changed the title fix: alternate bottomTab to look like before iPadOS 18 fix: [iPadOS 18] alternate bottomTab position back to bottom Dec 15, 2024
@maheshwaripurvesh maheshwaripurvesh changed the title fix: [iPadOS 18] alternate bottomTab position back to bottom fix: [iPadOS 18] Disable the new UITabBarController view style in iPadOS 18 Dec 15, 2024
Copy link

stale bot commented Jan 31, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Jan 31, 2025
@aschmitz-wbd
Copy link

There is an issue #7926 for that and I want to mention here, that I think it should just be disabled outright. Since it's the native behavior of the iPad, there should at least be an option to turn it off and not have it disabled in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants