-
Notifications
You must be signed in to change notification settings - Fork 734
fix: 🐛 status bar manager issue with new rn fabric #3329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
+1 |
+1 |
I applied the changes in this PR as a patch in my project and worked fine. |
+1 |
@ethanshar is there anything we can do to help get this merged? The library is currently unusable on new builds. |
I'm in the same boat, my app is crashing until this is merged @ethanshar or any other maintainers, if we can merge this it would be super appreciated. |
@Inbal-Tish do you mind helping out here? |
+1 |
@sivantha96 you should consider resolving the conflicts first @ethanshar or @nitzanyiz any chance to get this merged? It's getting hard to upgrade to react native 0.76 with this issue around. |
Hi team! |
Hi! |
Description
Fixed the issue where it throws a runtime error for projects which has React Native Fabric (New Architecture) enabled.
Changelog
Removed
StatusBarManager
and used the official React Native's StatusBar module to get the current height of the status bar when thesetStatusBarHeight
function is called.Also fixed some unit test case failures and did some code improvements.
Additional info
Fixes #3320