Skip to content

fix: 🐛 status bar manager issue with new rn fabric #3329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

sivantha96
Copy link
Contributor

Description

Fixed the issue where it throws a runtime error for projects which has React Native Fabric (New Architecture) enabled.

Changelog

Removed StatusBarManager and used the official React Native's StatusBar module to get the current height of the status bar when the setStatusBarHeight function is called.

Also fixed some unit test case failures and did some code improvements.

Additional info

Fixes #3320

@ethanshar ethanshar self-requested a review October 30, 2024 11:15
@ethanshar ethanshar self-assigned this Oct 30, 2024
@sivantha96
Copy link
Contributor Author

+1

@borstessi
Copy link

+1

@felipejh
Copy link

felipejh commented Nov 9, 2024

I applied the changes in this PR as a patch in my project and worked fine.

@thejoaov
Copy link

+1

@brycelund
Copy link

@ethanshar is there anything we can do to help get this merged? The library is currently unusable on new builds.

@yasuf
Copy link

yasuf commented Nov 24, 2024

I'm in the same boat, my app is crashing until this is merged @ethanshar or any other maintainers, if we can merge this it would be super appreciated.

@yasuf
Copy link

yasuf commented Nov 24, 2024

@Inbal-Tish do you mind helping out here?

@fjmorant
Copy link

+1

@ilteoood
Copy link

ilteoood commented Nov 25, 2024

@sivantha96 you should consider resolving the conflicts first

@ethanshar or @nitzanyiz any chance to get this merged? It's getting hard to upgrade to react native 0.76 with this issue around.

@nitzanyiz
Copy link
Collaborator

Hi team!
Seems like StatusBar doesn't give us the right height on IOS. I created a fix that will revert to the old method we had for getting the height if using StatusBar.currentHeight doesn't work. You can see #3425 . Theres also a snapshot version with the fix in the additional info, let us know if it works for.

@nitzanyiz
Copy link
Collaborator

Hi!
I'm closing this pr. This is fixed in #3425.

@nitzanyiz nitzanyiz closed this Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library does not work with React Native version 0.76.0
10 participants