Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TabBar - Better accessibility roles and instructions #3501

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

TabBar - Better accessibility roles and instructions #3501

wants to merge 5 commits into from

Conversation

nitzanyiz
Copy link
Collaborator

@nitzanyiz nitzanyiz commented Feb 12, 2025 •
edited
Loading

Description

  • Added tab accessibility role to the tab items and tablist role to the tab controller.
  • Added selected accessibility state - It was reading that everything was not selected, even when the tab was selected.
  • Remove the state and test the instructions it gives on a real device. When it is not passed it doesn't give feedback that the tab was selected and doesn't state if the tab is selected when you focus it.

We can give each tab item an isSelected state and change it accordingly so a state change will only effect the specific TabItem instead of handling it in the context scope and passing it down. wdyt?

Changelog

TabBar - Added better accessibility roles.

Additional info

MADS-4589

@nitzanyiz nitzanyiz requested a review from M-i-k-e-l February 12, 2025 12:31
@nitzanyiz nitzanyiz changed the title Fix/tab bar accessibility role TabBar - Better accessibility roles and instructions Feb 12, 2025
@nitzanyiz nitzanyiz marked this pull request as ready for review February 12, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-i-k-e-l M-i-k-e-l Awaiting requested review from M-i-k-e-l

At least 1 approving review is required to merge this pull request.

Assignees

@M-i-k-e-l M-i-k-e-l

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitzanyiz @M-i-k-e-l