Issue-9189 VS 2026 Support - #664
Closed
chrpai wants to merge 2 commits into
Closed
Conversation
Update vsca.cpp to search for VS18/2026 Updated Tests to look for VS2026_ROOT_FOLDER Cloned VS2022 wixlib fragment to VS2026 and replaced 2022 with 2026.
Added PropertyRef for VS2026_ROOT_FOLDER in test data and updated comments in VS2026.wxs to reference Visual Studio 2026 instead of 2019. This prepares the installer for future Visual Studio 2026 support.
Contributor
Author
|
I ran the devbuild locally and it generated the nupkg and said all tests passed. However when I tried to consume the nuget package in a test project it couldn't resolve any of the old properties or any of the new properties for tha matter. I don't think that means it doesn't work but rather there's just some developer test workflow I'm not familiar with. |
Contributor
Author
|
@robmen do I need to do anything to move this along? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update vsca.cpp to search for VS18/2026
Updated Tests to look for VS2026_ROOT_FOLDER
Cloned VS2022 wixlib fragment to VS2026 and replaced 2022 with 2026.