WZ-4506:Fixed Category URL issue when there is multiple stores. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smit-kandiya
force-pushed
the
WZ-4506
branch
3 times, most recently
from
ce589e6 to
faac839
Compare
alok0590
requested changes
Oct 22, 2024
| $this->allStoreBaseUrls = $this->storeManager->getAllStoreBaseUrls(); | ||
| } | ||
|
|
||
| $storeUrls = $this->allStoreBaseUrls; |
There was a problem hiding this comment.
$storeUrls = $this->allStoreBaseUrls;
Simply us $this->allStoreBaseUrls
Not required
| ; | ||
| } | ||
|
|
||
| $currentStoreBaseUrl = $this->currentStoreBaseUrl[$this->storeId]; |
There was a problem hiding this comment.
Check if
$this->currentStoreBaseUrl[$this->storeId] and isset($this->currentStoreBaseUrl[$this->storeId]['base_url'])
smit-kandiya
force-pushed
the
WZ-4506
branch
3 times, most recently
from
b9b9532 to
ea833f4
Compare
alok0590
requested changes
Oct 24, 2024
| } | ||
| } | ||
|
|
||
| $categoryUrl = $currentStoreBaseUrl."".$categoryUrl; |
There was a problem hiding this comment.
What if we did not find any URL and replaced it? Only append $currentStoreBaseUrl in the if condition above. And only if $currentStoreBaseUrl is set or not null
alok0590
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.