Skip to content

Fix compatibility with CMake 4.0 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix compatibility with CMake 4.0 #311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
cmake_minimum_required(VERSION 2.8.3)
cmake_minimum_required(VERSION 2.8.3...3.5)
Copy link

@peter-toft-greve peter-toft-greve Apr 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this enough for cmake 4? Don't we need 3.6 or higher?

Copy link
Author

@traversaro traversaro Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, CMake 4.0.0 is still compatible with the policy of CMake 3.5 (if you check the error message, it refers to "Compatibility with CMake < 3.5", not "Compatibility with CMake <= 3.5"). This will print a warning for any CMake version >= 3.31, but I wanted to make the least possible invasive change here.

Copy link

@peter-toft-greve peter-toft-greve Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good - who can approve?

Copy link
Author

@traversaro traversaro Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think the project is maintained, see #275 and #312 .

Copy link
Author

@traversaro traversaro Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I started a friendly fork with (among other things) CMake 4.0 support at https://github.com/ami-iit/serial_cpp, feel free to check it out.

Copy link

@mosfet80 mosfet80 Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake_minimum_required(VERSION 3.10) fix compatibility and deprecation warning

project(serial)

# Find catkin
Expand Down