Provide the ability to customize which tqdm object is used#389
Open
hmaarrfk wants to merge 2 commits intowkentaro:mainfrom
Open
Provide the ability to customize which tqdm object is used#389hmaarrfk wants to merge 2 commits intowkentaro:mainfrom
hmaarrfk wants to merge 2 commits intowkentaro:mainfrom
Conversation
Contributor
Author
|
hmm i just saw this: #241 Yea I agree to keep the API the same. I've basically just mocked the entire tqdm classes in my work. Let me know how you want me to adjust this! |
Contributor
Author
|
Linting PR made in #398 |
Contributor
Author
|
@wkentaro would you consider such a PR to allow for the customization of the tqdm progress bar? |
It is sometimes nice to be able to customize the tqdm object for example to use the jupyter enabled tqdm object. We actually have a few other "tqdm-like" objects that help use customize the progress bar on our interfaces. Thanks for considering!
Refactor progress bar handling to ensure it closes correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is sometimes nice to be able to customize the tqdm object for example to use the jupyter enabled tqdm object.
We actually have a few other "tqdm-like" objects that help use customize the progress bar on our interfaces.
Thanks for considering!