test: cover dtype converter validation guards#190
Open
wkentaro wants to merge 1 commit into
Open
Conversation
bool2ubyte and float2ubyte had four input-validation guards but no error-path tests. Cover bool2ubyte rejecting a non-bool dtype, and float2ubyte rejecting a non-float dtype, values below 0, and values above 1.
wkentaro
force-pushed
the
test/dtype-validation-coverage
branch
from
e201a08 to
d6523ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bool2ubyteandfloat2ubytehad four input-validation guards but noerror-path tests.
Summary
bool2ubyterejecting a non-bool dtype.float2ubyterejecting a non-float dtype, values below 0, and valuesabove 1.
Test plan
uv run pytest tests/unit/_dtype_test.py(6 passed)uv run --extra all pytest -n=auto tests(251 passed)uv run ruff check,ruff format --check,ty checkon the changed file