test: cover normalize multichannel, NaN, and validation paths#194
Draft
wkentaro wants to merge 1 commit into
Draft
test: cover normalize multichannel, NaN, and validation paths#194wkentaro wants to merge 1 commit into
wkentaro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalizeonly had happy-path coverage; its multichannel branch, NaN handling,and four validation/warning guards were untested.
Summary
poisons the whole pixel in a multichannel image.
ndim,min_value.shape, andmax_value.shapeValueErrorguards.infUserWarningemitted when a min or max value is infinite.Test plan
uv run pytest tests/unit/_normalize_test.py(11 passed)uv run --extra all pytest -n=auto tests(255 passed)uv run ruff check,ruff format --check,ty checkon the changed file