test: cover flow2rgb validation guards and Flow2Rgb max_norm caching#198
Draft
wkentaro wants to merge 1 commit into
Draft
test: cover flow2rgb validation guards and Flow2Rgb max_norm caching#198wkentaro wants to merge 1 commit into
wkentaro wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flow2rgbandFlow2Rgbonly had happy-path coverage; the three input-validationguards and the class's
max_normcaching were untested.Summary
ndim, channel-count, and dtypeValueErrorguards inflow2rgb.return_max=Truebranch (reports the computed max norm, output staysconsistent when that norm is reused).
Flow2Rgbcaching the first frame'smax_normand not recomputing it onlater frames, plus an explicitly-constructed
max_normbeing preserved.Test plan
uv run pytest tests/unit/_flow_test.py(9 passed)uv run --extra all pytest -n=auto tests(257 passed)uv run ruff check,ruff format --check,ty checkon the changed file