refactor(draw): extract require_pil_image guard into _ink#207
Draft
wkentaro wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #192.
The in-place draw primitives
line_andpolygon_each repeated the samethree-line PIL image type guard. This extracts it into
require_pil_imageinimgviz/draw/_ink.py, alongside the existingrequire_fill_or_outline, andreplaces both inline copies. Behavior and the
TypeErrormessage are unchanged.Summary
require_pil_image(image)toimgviz/draw/_ink.py.line_andpolygon_with a call to it.Scope note: only
line_andpolygon_carry the inline guard onmaintoday(
arrow_arrives with #193 and can adopt the helper there). The other in-placeprimitives (
circle_,ellipse_,rectangle_, etc.) never had a guard;applying one to them is a behavior change (they would start raising
TypeErrorinstead of a Pillow
AttributeError), so that uniform rollout is trackedseparately rather than folded into this dedupe.
Test plan
uv run --extra all pytest -n=auto tests(251 passed)polygon_"rejects non-PIL image" test still passes, exercising the extracted helperuv run ruff check,ty checkon the touched files