feat: add draw.progress_bar overlay primitive#209
Draft
wkentaro wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
imgviz.draw.progress_bar(image, yx1, yx2, value, fill, background, outline=None)and its in-place pairprogress_bar_, for inline horizontal progress bars (confidence indicators, quality scores, tile-sheet strips).valueis clamped to [0, 1]: 0 draws the track only, 1 fills it fully. Composesdraw.rectangle_(track + filled portion + optional outline); the fill rect is skipped at value 0 to avoid a zero-width rectangle.outline(notborder) and requiresfill/backgroundwith no defaults, matching the rest of thedrawmodule.Test plan
tests/unit/draw/_progress_bar_test.py— value 0 (track only), value 1 (fully filled), half-fill pixel check, clamping (1.5 and -1.0), outline drawn at every fill level, outline does not overpaint the interior, and in-place mutationuv run python examples/progress_bar.py --save; README table refreshed viagenerate_readme.pyuv run pytest tests/unit/draw/_progress_bar_test.py— 11 passeduv run ruff check/uv run ruff format --check/uv run ty checkclean on touched files (incl. test + example)Closes #132