Hackathon feedback - #5
Conversation
- clarify the byte ordering of the combined field containing RESPONSE-CODE and INFO-CODE - forbid multiple EDE options per message
|
Pushed some more changes based on Shane's feedback on the mailing list:
Comments from Shane that are not yet addressed:
|
Stephane Bortzmeyer worked on implementing EDE in Knot the hackathon in Prague, and mentioned a few issues that came up:
INFO-CODE bit layout was a bit ambiguous as it's a 12-bit field and "byte order" isn't meaningful. The packet layout diagram helps, but we could help by specifing in the text that the combined response and info fields are two octets in network byte order, and RESPONSE-CODE is the most significant four bits and INFO-CODE is the least significant 12.
He requested the addition of a generic error code for SERVFAIL responses that don't fall into any defined category. For example, it's possible to configure Knot to send SERVFAIL as a result of a policy decision, which doesn't fall into any of the existing buckets, and it would seem silly to add a specific bucket for that.
Finally, he recommended removal of the suggestion in section 3.2 that multiple EDE records could be included with a response, and instead forbid it. It makes parsing harder, and it's unclear what to do if different codes contradict one another.
Incidental point that I noticed while checking the existing text: "The authors wish to thank...Evan
Hunt" looks weird if I'm one of authors...