PPC64 support. Stumbled upon a minor bug in kallsym lookup. #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2025 15:20
Signed-off-by: Anders Grahn <anders.grahn@westermo.com>
Fixup the kallsym sort-compare function. Sorting the kallsyms breaks when comparing addresses that are more than INT_MAX bytes apart. The could break e.g. the stack or caller output. Seen on a ppc64 Linux kernel where kernel memory is divided into different address regions. Kernel modules are placed at 0xc0000100xxxxxxx and the core kernel at 0xc000000xxxxxxx. Signed-off-by: Anders Grahn <anders.grahn@westermo.com>
wkz
approved these changes
Dec 2, 2025
Owner
wkz
left a comment
wkz
left a comment
There was a problem hiding this comment.
Good catch on the sort bug! Thanks! 🥇
|
Hi, this is super cool, thanks for adding support! I assume that this code would also work fine on powerpc64le? Currently, when building for ppc64le, I see |
Owner
I think that's a reasonable assumption. If you want, try to add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically copy-pasted powerpc.c, some minor edits. Found a small issue in kallsym lookup during testing.