[CPyCppyy] Add smart pointer conversion policy flag and remove local memory heuristics flag #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steering the memory policy locally at the level of methods and functions is redundant, because one can always define pythonizations that take care of that. Removing this feature allows us to add new policy flags without increasing the net complexity of the library. With this feature removed, one single bool flag to indicate the heuristic memory policy is enough, because there is no need to use 4 bits to encode the combination of local and global policies anymore.
In ROOT, we need to disable this for type safety and overload resolution reasons.
guitargeek
added a commit
to guitargeek/cppyy
that referenced
this pull request
Aug 15, 2025
Goes together with: * wlav/CPyCppyy#63
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the local memory policy attribute feature, because
1 ) cppyy uses by default the strict memory policy anyway
2 ) ROOT doesn't need it
3) the same result can be achieved with pythonizations
4) simplifying code is good
On the other hand, introduce a new policy to control the implicit conversion to smart pointer arguments, which we would like to not to have in ROOT. So far, I just patched it out in ROOT, but to avoid a patch, it would be better to be able to change this via static flags.
Corresponds to:
More detail in the commit description.
Goes together with this PR that updates the tests:
SetMemoryPolicytoSetHeuristicMemoryPolicycppyy#318