Skip to content

Fix: Update platformio_override.sample.ini #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: Update platformio_override.sample.ini #4617

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3845bbf
Fix: Update platformio_override.sample.ini
huckley Mar 27, 2025
f41379c
Update platformio_override.sample.ini
huckley Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion platformio_override.sample.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,7 @@ monitor_filters = esp32_exception_decoder
# 433MHz RF remote example for esp32dev
[env:esp32dev_usermod_RF433]
extends = env:esp32dev
build_flags = ${env:esp32dev.build_flags} -D USERMOD_RF433
build_flags = ${env:esp32dev.build_flags}
Copy link

@Arcitec Arcitec Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually redundant now and would work equally well if deleted. If deleted, it automatically inherits those exact build flags from the extends.

The ${env:esp32dev.build_flags} is however vitally important if the user wants to add extra WLED build flags that configure the usermod, so the example should still stay.

But maybe change it to this:

;; Uncomment and append your own build flags here if you want to configure the usermod:
; build_flags = ${env:esp32dev.build_flags}

custom_usermods = usermod_v2_RF433
lib_deps = ${env:esp32dev.lib_deps}
Copy link

@Arcitec Arcitec Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entire lib_deps statement should be deleted too. That's handled automatically by the PlatformIO Libraries feature we use now.

In this case it's handled here now:

https://github.com/wled/WLED/blob/main/usermods/usermod_v2_RF433/library.json

So users only need to set custom_usermods, nothing else. :)

sui77/rc-switch @ 2.6.4