feat: drop Python 3.8 #1004
Merged
feat: drop Python 3.8 #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/drop38
branch
2 times, most recently
from
ec5ae9e to
8193d7f
Compare
theacodes
approved these changes
Oct 13, 2025
Collaborator
theacodes
left a comment
theacodes
left a comment
There was a problem hiding this comment.
This looks good, but it looks like it caused our coverage to drop a tiny amount. Feel free to merge it once that's good.
henryiii
force-pushed
the
henryiii/feat/drop38
branch
from
b269d8d to
bfaa334
Compare
henryiii
force-pushed
the
henryiii/feat/drop38
branch
from
bfaa334 to
f038a32
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/drop38
branch
from
f038a32 to
3833b51
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/drop38
branch
from
ba4274d to
dae2162
Compare
Collaborator
Author
|
I don't know why 3.8 was picking up subprocess calls, but 3.9+ wasn't. Anyway, we can use coverage's new(ish, a few months old) patch feature to enable this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be dropping 3.9 soon, but we still support 3.8. Let's drop that so a future version can drop 3.9. (For running, not targeting).