chore(ci): cliff.toml 支持 conventional scope + bump 1.8.1#63
Merged
Conversation
旧正则 `(?i)^fix[：:]` 要求 type 后立即跟冒号,带 scope 的 commit(如
`fix(arena):`)被 fallthrough 到 `{ message = ".*", skip = true }`,
导致历史所有 `fix(security):` / `feat(arena):` 类 commit 都不进 changelog。
加上可选的 scope 后缀 `(\(.+?\))?` 后,无 scope 与带 scope 的两种
都能匹配并归到对应 emoji 分组。
There was a problem hiding this comment.
Pull request overview
This PR updates the release tooling to correctly categorize scoped Conventional Commits in git-cliff changelog generation, and bumps the Tauri app version to 1.8.1 for the upcoming release.
Changes:
- Update
.github/cliff.tomlcommit_parsersregex to recognize optional(scope)in commit headers. - Bump
src-tauri/tauri.conf.jsonapp version from1.8.0to1.8.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lol-record-analysis-tauri/src-tauri/tauri.conf.json | Bumps the app version to 1.8.1 for release tagging/build metadata. |
| .github/cliff.toml | Adjusts git-cliff commit parsing to classify scoped Conventional Commits into the correct changelog groups. |
Comments suppressed due to low confidence (1)
.github/cliff.toml:42
- Same regex issue as above: the
\(.+?\)fragment uses+?(lazy quantifier) which may not be supported by git-cliff’s regex engine and can break the release workflow when generating the changelog. Replace the scope portion with a Rust-regex-compatible character class like\([^)]*\)and keep it optional.
{ message = "(?i)^style(\\(.+?\\))?[：:]", group = "🎨 Styling" },
{ message = "(?i)^test(\\(.+?\\))?[：:]", group = "🧪 Testing" },
{ message = "^chore\\(release\\): prepare for", skip = true },
{ message = "(?i)^chore(\\(.+?\\))?[：:]", skip = true },
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+34
to
+38
| { message = "(?i)^feat(\\(.+?\\))?[：:]", group = "🚀 Features" }, | ||
| { message = "(?i)^fix(\\(.+?\\))?[：:]", group = "🐛 Bug Fixes" }, | ||
| { message = "(?i)^doc(\\(.+?\\))?[：:]", group = "📚 Documentation" }, | ||
| { message = "(?i)^perf(\\(.+?\\))?[：:]", group = "⚡ Performance" }, | ||
| { message = "(?i)^refactor(\\(.+?\\))?[：:]", group = "🛠 Refactor" }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(scope)— 旧正则(?i)^fix[：:]要求 type 后立刻跟冒号,带 scope 的 commit (fix(arena):/feat(security):等) 全部被 fallthrough 到skip = true,历史所有 scoped commit 都漏出 changelog。加(\(.+?\))?可选段后,有/无 scope 都正确归类。Test plan
npm run check通过