docs: 修正 BINARY_CACHE 注释(实际无 TTL/上限、weigher 未生效)#73
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR corrects misleading documentation around the Tauri asset binary cache so the comment matches the current moka cache configuration and runtime behavior.
Changes:
- Clarifies that
BINARY_CACHEhas no TTL or capacity limit. - Notes that the configured
weigheris inactive unlessmax_capacityis added. - Documents the tradeoff of enabling capacity-based eviction later.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asset.rs里BINARY_CACHE原注释写"weighted size-based eviction (still useful)",与实现不符:builder 设了weigher但没有max_capacity,moka 只有在配了max_capacity时才按权重驱逐 → 当前永不过期、永不驱逐,weigher 形同虚设。背景
排查"图标偶发不显示"时确认:图标闪烁仅来自冷启动缓存填充窗口,与缓存淘汰无关(因为根本不淘汰)。顺手把误导性注释修正。
Test plan
cargo fmt --check通过cargo clippy --all-targets --all-features -Dwarnings通过