#1025 Fix bundleless builds in maven projects#1027
Merged
hugithordarson merged 2 commits intowocommunity:masterfrom Nov 9, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Think we got it this time, a fix that actually makes sense (for #1025).
ERXApplication.Loaderchecks the classpath to see if any of the entries are class/build folders (dynamically generated by Eclipse). It will then check if that entry's folder hierarchy contains a.projectfile, then check if that's a WO project and if so, make a ProjectBundle out of that.Problem was that the Loader only checked for classpath entries ending with
/bin(old style). In Maven projects however, these end with/target/classesinstead so this fix adds a check for that.Found a Wonder project and started it up. At a glance everything seems to work, and the following code:
Generates the following expected output when running in bundleless mode (the
NSMavenProjectBundlesbeing open projects).