wolfHSM integration #511
Merged
wolfHSM integration #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
force-pushed
the
wolfhsm-integration
branch
from
bc32c21 to
59429a4
Compare
Contributor
Author
|
rebased to fix merge conflicts that arose since filing the PR (just to config files), no code changes introduced |
dgarske
previously requested changes
Oct 29, 2024
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Looking good. All minor feedback
billphipps
previously approved these changes
Oct 30, 2024
Contributor
billphipps
left a comment
billphipps
left a comment
There was a problem hiding this comment.
Awesome! Minor nits. Update if you want. A couple of questions.
bigbrett
force-pushed
the
wolfhsm-integration
branch
from
59429a4 to
5cc9950
Compare
bigbrett
force-pushed
the
wolfhsm-integration
branch
from
5cc9950 to
ca85bdc
Compare
Contributor
Author
|
@dgarske addressed review comments and rebased to fix conflicts introduced by some of the latest PRs. |
billphipps
previously approved these changes
Nov 1, 2024
danielinux
previously requested changes
Nov 12, 2024
Member
danielinux
left a comment
danielinux
left a comment
There was a problem hiding this comment.
Looks good, and documentation is complete. Just a minor thing, the new options in keygen.c: I see those are mentioned in the keystore doucment, they should be also breifly mentioned in signing.md, as all the command line options for the key tools are usually grouped there.
danielinux
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds wolfHSM client support to wolfBoot.
Initial support for the following targets:
wolfHSM offload has been added for the following algorithms:
Additional changes: