Refactor Makefiles to allow overriding library paths #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
previously approved these changes
Sep 30, 2025
dgarske
reviewed
Sep 30, 2025
Contributor
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
FYI: Build output changes to absolute paths in logs. Not critical, but is a bit verbose now.
[CC ARM] lib/wolfssl/wolfcrypt/src/port/arm/armv8-aes.o
[CC ARM] lib/wolfssl/wolfcrypt/src/port/arm/armv8-chacha.o
[CC ARM] lib/wolfssl/wolfcrypt/src/port/arm/armv8-sha256.o
[CC ARM] lib/wolfssl/wolfcrypt/src/port/arm/armv8-sha512.o
[CC ARM] /home/davidgarske/GitHub/wolfboot/lib/wolfssl/wolfcrypt/src/port/arm/armv8-aes.o
[CC ARM] /home/davidgarske/GitHub/wolfboot/lib/wolfssl/wolfcrypt/src/port/arm/armv8-chacha.o
[CC ARM] /home/davidgarske/GitHub/wolfboot/lib/wolfssl/wolfcrypt/src/port/arm/armv8-sha256.o
[CC ARM] /home/davidgarske/GitHub/wolfboot/lib/wolfssl/wolfcrypt/src/port/arm/armv8-sha512.o
danielinux
reviewed
Oct 1, 2025
danielinux
requested changes
Oct 1, 2025
Member
danielinux
left a comment
danielinux
left a comment
There was a problem hiding this comment.
Remove excessive warnings from docs/compile.md. Submodule tracking is still the preferred mechanism to link dependencies, and each release is tracked (and tested) against one specific commit of each repository.
danielinux
approved these changes
Oct 2, 2025
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for the user to build wolfBoot against a different version of internal library dependencies (
wolfHSM,wolfTPM, etc) if they want to live dangerously.Also adds a CI action to ensure basic configurations for each library still build when using external paths.
The default behavior remains the same (points to
lib/*)