-
Notifications
You must be signed in to change notification settings - Fork 133
Introduce new wolfboot image inspection scripts #621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
danielinux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a good idea.
- Is there any plan to cover more hash / public key algorithms in image_peek.py?
- The wolfboot-der-to-spki.py tool could have a better name hinting at ECC, since it only covers ECC.
92ace91 to
e3920b8
Compare
Yes, definitely, in future PR as needed & time permits
Good point. Renamed |
dgarske
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer a --read option for the tools/keygen/sign tool, but this is nice too.
Did you notice a read .py script that does something similar?
https://github.com/wolfSSL/wolfBoot/blob/master/tools/scripts/boot_status.py
Anyway to expand that?
| @@ -0,0 +1,133 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of this script needs changed. keystore to der?
| # Convert wolfBoot raw/public-key container to standard SPKI DER/PEM, next to input. | ||
| # Usage: | ||
| # | ||
| # ./tools/scripts/wolfboot-ecc-der-to-spki.py ./tools/keytools/keystore.der |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keystore.der is in root, not tools/keytools
wolfBoot image peek
While working on #614, I needed a tool to objectively validate a wolfboot-signed image.
Enclosed are new
tools/scripts:wolfboot-der-to-spki.py- Convert wolfBoot raw/public-key container to standard SPKI DER;This is a helper needed for
image-peek.py- see below.image-peek.py- peek at a wolfBoot-signed image and display various diagnostic detailsExample:
test-lib
This is in addition to the
test-libapp, problematic validation shown here for reference:See also my new VS2022
wolfBootTestLib.vcxprojvalidation app: in my tools/keytools. (PR soon)Spoiler:
Root cause of at least one of my validation failures was the wrong
user_settings.h:./tools/keytools/user_settings.h vs ./include/user_settings.h