Improve otp_keystore checks, add explicit TARGET_sim check #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielinux
requested review from
danielinux
and removed request for
wolfSSL-Bot
danielinux
requested changes
Nov 11, 2025
Member
danielinux
left a comment
danielinux
left a comment
There was a problem hiding this comment.
What is the purpose of the simulated otp? Is this for building with TARGET=sim ? If this is the case please add the associated tests as github actions
Contributor
Author
|
The simulated otp target is introduced for my wolfBootFlashOTP.vcxproj Visual Studio project, specifically here. I already have a test for the msbuild of There's already a pending PR for Visual Studio projects and tests in #623 , but it doesn't have the I've been trying to keep each PR restricted to a specific topic rathe than one massive monolith. |
Contributor
Author
|
Leaving OTP alone per #635 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
KEYSTORE_HDR_MAGICassignment to avoid MSVC complaint about a non-nul-terminated string.Add
TARGET_simand respective otp stub files.Add additional compile time checks.