Skip to content

Conversation

@Yu-Ma28051503
Copy link
Contributor

The following items have not yet been implemented,

  • Smallstack macro
  • test script

@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@JacobBarthelmeh
Copy link
Contributor

Ok to test Jenkins

@JacobBarthelmeh
Copy link
Contributor

The FIPS CI failure is due to more restrictive algorithms now. Removing the use of DES and causing decryption of DES encrypted keys to fail. This PR (#183) adjusts the test cases to account for that.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for generating Chimera certificates, which implement dual-algorithm cryptography combining traditional ECC with post-quantum ML-DSA signatures. The implementation includes new command-line options, key generation functionality for ML-DSA, and a comprehensive certificate generation function that creates certificates with dual cryptographic signatures.

  • Adds ML-DSA key generation capabilities alongside existing Dilithium support
  • Implements Chimera certificate generation with dual ECC/ML-DSA signatures
  • Extends CA setup with new command-line options for alternate keys and extended signing modes

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
wolfclu/x509/clu_x509_sign.h Adds function declaration for Chimera certificate generation
wolfclu/genkey/clu_genkey.h Adds ML-DSA key generation function declaration with documentation
wolfclu/clu_optargs.h Defines new command-line option constants for alternate keys and extended signing
tests/x509/expect-purpose.txt Updates test expectation for TLS Web Client Authentication
src/x509/clu_x509_sign.c Implements comprehensive Chimera certificate generation function
src/x509/clu_ca_setup.c Extends CA setup with new options and alternate signing workflow
src/tools/clu_funcs.c Adds ML-DSA to help documentation
src/genkey/clu_genkey_setup.c Adds ML-DSA key generation setup and argument parsing
src/genkey/clu_genkey.c Implements ML-DSA key generation functionality
README.md Documents Chimera certificate creation workflow with examples

@JacobBarthelmeh
Copy link
Contributor

@Yu-Ma28051503 please assign to wolfSSL-bot or ping me on slack when ready for a re-review.

@Yu-Ma28051503 Yu-Ma28051503 removed their assignment Aug 22, 2025
Copy link
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test cases! Please resolve the CI reports.

@JacobBarthelmeh JacobBarthelmeh merged commit 7fb2bc9 into wolfSSL:main Sep 2, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants