Debug macro fix #250
Open
Debug macro fix #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbrett
requested changes
Nov 20, 2025
src/wh_utils.c
Outdated
| if ((count % HEXDUMP_BYTES_PER_LINE) == 0) { | ||
| linePos = 0; | ||
| } | ||
| linePos += snprintf(line + linePos, sizeof(line) - linePos, "%02X ", *ptr); |
Contributor
There was a problem hiding this comment.
so you are reintroducing printfs here? Seems to defeat the purpose of having the WOLFHSM_CFG_PRINTF macro
Contributor
Author
There was a problem hiding this comment.
The snprintf was for formatting, I will change it. There are some other snprintf occurrences as well still in the code base for smilier reasons. Working on change now.
Contributor
Author
There was a problem hiding this comment.
Changing to manually converting bytes instead of relying on snprintf
Contributor
There was a problem hiding this comment.
I think if we use them in other places and they are legit needed then we should probably have our own internal macro for it. Preference to removing the need for it unless absolutely necessary but it might be a bigger change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test verbose macros to use WOLFHSM_CFG_DEBUG_VERBOSE
in all test files to match Makefile DEBUG_VERBOSE=1 variable
to prevent interleaved output