Skip to content

Conversation

@kaabia
Copy link
Contributor

@kaabia kaabia commented Nov 9, 2025

Fixed incorrect variable usage in error checking:

  • In MqttDecode_PublishResp: Changed 'tmp' to 'props_tmp' in error check
  • In MqttDecode_UnsubscribeAck: same change.

This resolves potential issues where property decode errors could be missed by checking the wrong variable during MQTT v5.0 message processing.

Fixed incorrect variable usage in error checking:
- In MqttDecode_PublishResp: Changed 'tmp' to 'props_tmp' in error check
- In MqttDecode_UnsubscribeAck: same change.

This resolves potential issues where property decode errors could be
missed by checking the wrong variable during MQTT v5.0 message
processing.

Signed-off-by: Badr Bacem KAABIA <[email protected]>
@wolfSSL-Bot
Copy link

Can one of the admins verify this patch?

@embhorn embhorn self-requested a review November 10, 2025 15:18
@embhorn embhorn self-assigned this Nov 10, 2025
Copy link
Member

@embhorn embhorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@embhorn embhorn merged commit 0a6d2e3 into wolfSSL:master Nov 10, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants