Implement FIPS support for testing scripts and fix FIPS AES cmd test#191
Merged
Conversation
padelsbach
reviewed
Jun 26, 2025
aidangarske
force-pushed
the
fips-test-support
branch
from
7cb1f2a to
bc949e5
Compare
aidangarske
changed the title
padelsbach
reviewed
Jul 6, 2025
padelsbach
left a comment
padelsbach
left a comment
Contributor
There was a problem hiding this comment.
Nice improvement, but a couple concerns
padelsbach
approved these changes
Jul 7, 2025
padelsbach
left a comment
padelsbach
left a comment
Contributor
There was a problem hiding this comment.
Looks great, nice improvements. Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WOLFPROV_DEBUGWOLFSSL_ISFIPSenv variable that gets passed in to testing scripts to enable FIPS mode testing../scripts/do-cmd-test.shwith running AES-CFB with FIPS modescripts/test-sanity.shandscripts/test-wp-cs.shwork with FIPS and withoutscripts/test-openssl.shis broken with FIPS, master, and v5.8.0-stable with openssl-3.5.0 no matter what combo. Already disabled in jenkins though.init_wolfprovso we dont fail unit test for testing