Add wolfJCE RSA KeyFactory Implementation #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds RSA KeyFactory support to the wolfJCE provider, enabling conversion and management of RSA keys across different formats. The implementation includes comprehensive test coverage and JNI bindings for exporting/importing CRT parameters.
- Adds complete RSA KeyFactory implementation with support for various KeySpec formats (X509, PKCS8, RSAPublicKeySpec, RSAPrivateCrtKeySpec, RSAPrivateKeySpec)
- Implements separate key classes for RSA public keys, CRT private keys, and non-CRT private keys
- Adds JNI native methods for exporting and importing RSA CRT key parameters
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| WolfCryptRSAKeyFactory.java | Main KeyFactory implementation for RSA key format conversions |
| WolfCryptRSAPublicKey.java | RSAPublicKey implementation with X.509 encoding support |
| WolfCryptRSAPrivateCrtKey.java | RSAPrivateCrtKey implementation with full CRT parameters |
| WolfCryptRSAPrivateKey.java | RSAPrivateKey implementation for non-CRT keys |
| WolfCryptRSAKeyFactoryTest.java | Comprehensive test suite with 15 test methods |
| jni_rsa.c | JNI bindings for wc_RsaExportCrtKey and wc_RsaImportCrtKey |
| Rsa.java | Java wrappers for new native export/import methods |
| WolfCryptProvider.java | Registers RSA KeyFactory service |
| WolfCryptCipher.java | Updates error message for clarity |
| README_JCE.md | Documents new RSA KeyFactory support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/com/wolfssl/provider/jce/test/WolfCryptRSAKeyFactoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/wolfssl/provider/jce/test/WolfCryptRSAKeyFactoryTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/wolfssl/provider/jce/test/WolfCryptRSAKeyFactoryTest.java
Show resolved
Hide resolved
cconlon
force-pushed
the
rsaKeyFactory
branch
2 times, most recently
from
64308a4 to
6c631c6
Compare
Merged
4 tasks
cconlon
force-pushed
the
rsaKeyFactory
branch
from
6c631c6 to
d8c00d6
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 24 out of 24 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cconlon
force-pushed
the
rsaKeyFactory
branch
from
d8c00d6 to
bf90812
Compare
…nerated header files
…for RSA KeyFactory usage
cconlon
force-pushed
the
rsaKeyFactory
branch
from
bf90812 to
fca84fe
Compare
rlm2002
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds our own implementation of RSA KeyFactory (
KeyFactory.getInstance('RSA')).Additions include:
WolfCryptRSAKeyFactory: Handles key generation from specs (RSAPrivateCrtKeySpec,RSAPrivateKeySpec,RSAPublicKeySpec,X509EncodedKeySpec,PKCS8EncodedKeySpec) and key translationWolfCryptRSAPrivateCrtKey: CRT-enabled RSA private keys (implementsRSAPrivateCrtKey)WolfCryptRSAPrivateKey: Non-CRT RSA private keys (implementsRSAPrivateKeyonly)WolfCryptRSAPublicKey: RSA public key implementationwc_RsaImportCrtKey()andwc_RsaExportCrtKey()for raw RSA parameter import/exportUnit tests included for testing and regression.