Skip to content

Conversation

@cconlon
Copy link
Member

@cconlon cconlon commented Nov 10, 2025

This PR adds OID alias support for SHA-224, SHA-256, SHA-384, and SHA-512 MessageDigest algorithms in the wolfJCE provider.

  • Registers OID aliases (2.16.840.1.101.3.4.2.x) for SHA-2 family algorithms in WolfCryptProvider
  • Adds test cases verifying MessageDigest can be retrieved by OID and produces identical output
  • Update README_JCE.md with supported OID values

Allows users to obtain MessageDigest instances using standard NIST OIDs instead of algorithm names

@cconlon cconlon self-assigned this Nov 10, 2025
@cconlon cconlon requested a review from Copilot November 10, 2025 20:59
Copilot finished reviewing on behalf of cconlon November 10, 2025 21:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds OID alias support for SHA-2 family MessageDigest algorithms (SHA-224, SHA-256, SHA-384, and SHA-512) in the wolfJCE provider, allowing users to obtain MessageDigest instances using standard NIST OIDs.

  • Registers OID aliases (2.16.840.1.101.3.4.2.x) for SHA-2 algorithms in WolfCryptProvider
  • Adds test cases verifying MessageDigest retrieval by OID produces identical output to algorithm name
  • Updates README_JCE.md documentation with supported OID values

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/com/wolfssl/provider/jce/WolfCryptProvider.java Registers OID aliases for SHA-224, SHA-256, SHA-384, and SHA-512 MessageDigest algorithms
src/test/java/com/wolfssl/provider/jce/test/WolfCryptMessageDigestSha224Test.java Adds testSha224OidAlias test case
src/test/java/com/wolfssl/provider/jce/test/WolfCryptMessageDigestSha256Test.java Adds testSha256OidAlias test case
src/test/java/com/wolfssl/provider/jce/test/WolfCryptMessageDigestSha384Test.java Adds testSha384OidAlias test case
src/test/java/com/wolfssl/provider/jce/test/WolfCryptMessageDigestSha512Test.java Adds testSha512OidAlias test case
README_JCE.md Documents OID values for SHA-2 family algorithms

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cconlon cconlon assigned rlm2002 and unassigned cconlon Nov 10, 2025
@rlm2002 rlm2002 merged commit 8b7469d into wolfSSL:master Nov 10, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants