JNI/JCE: fix pointer use in JNI X509CheckPrivateKey() #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacobBarthelmeh
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the native JNI
X509CheckPrivateKey()function to operate on a copy of the pointer topkcs8KeyDerArr.Recent changes in native wolfSSL as of wolfSSL/wolfssl@901384e704#diff-34d62efe7620eac9235c878aafc6716d1ef20a2246a35fac977f34bacce0481cR7315 caused the wolfSSL API
wolfSSL_d2i_PKCS8_PKEY()to advance the input key buffer pointer.Since the pointer can now be advanced, that can cause a crash in JNI when calling
ReleaseByteArrayElements()on that pointer.Fixes https://cloud.wolfssl-test.com/jenkins/job/wolfSSL/job/nightly-FIPSv2-wolfcrypt-jni-ant-test-v2