Add negative tests for AEAD, PKCS7, PSS, DSA, DRBG, and PQ key#10291
Merged
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10291
No scan targets match the changed files in this PR. Review skipped.
|
JeremiahM37
force-pushed
the
test-coverage
branch
4 times, most recently
from
22da37f to
f107414
Compare
Contributor
Author
|
Jenkins retest this please |
dgarske
requested changes
May 5, 2026
JeremiahM37
force-pushed
the
test-coverage
branch
3 times, most recently
from
9603eca to
9922008
Compare
dgarske
previously approved these changes
May 7, 2026
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Again, very surprised this didn't propigate any errors. I sent you a note to double check things (force a failure to make sure its actually reported). For now marking approved, but holding merge since it did not change/fix any core code...
JeremiahM37
force-pushed
the
test-coverage
branch
3 times, most recently
from
63c00ae to
92654be
Compare
JeremiahM37
force-pushed
the
test-coverage
branch
2 times, most recently
from
a922d6e to
a205750
Compare
JeremiahM37
force-pushed
the
test-coverage
branch
from
a205750 to
efe98a7
Compare
Contributor
Author
|
Jenkins retest this please |
SparkiDev
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses F-2195, F-2204, F-2198, F-2199, F-3072, F-3073, F-2640, F-2643, F-3074.
wc_PKCS7_RsaVerifyrecovered-digestXMEMCMPandwc_PKCS7_EcdsaVerifyres==1guard.0xbcterminator; assertsBAD_PADDING_Especifically.reseedCtr = WC_RESEED_INTERVAL - 1and verifies the boundary check fires (counter resets after next generate).H(ek)of an encoded private key blob; assertsMLKEM_PUB_HASH_E.key->skafter import; assertswc_SlhDsaKey_CheckKeyreturnsWC_KEY_MISMATCH_E.answer == 0via the finalmp_cmp(r, v)check.