Skip to content

Fix AES multiblock issues for NXP DCP#10307

Merged
dgarske merged 1 commit into
wolfSSL:masterfrom
padelsbach:nxp-aes-multiblock
May 5, 2026
Merged

Fix AES multiblock issues for NXP DCP#10307
dgarske merged 1 commit into
wolfSSL:masterfrom
padelsbach:nxp-aes-multiblock

Conversation

@padelsbach

@padelsbach padelsbach commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes in wolfcrypt/src/port/nxp/dcp_port.c:

  1. AES CBC encrypt was saving the wrong block for subsequent calls. One block calls work, but multi-block did not. Existing tests did not hit this scenario.
  2. Same issue for decrypt
  3. In decrypt, special case of in == out required copy to temp buffer for chaining.

Added test cases for all 3.

Fixes F-2644, F-2645

Testing

How did you test?

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@github-actions

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@padelsbach padelsbach marked this pull request as ready for review April 24, 2026 21:51

@wolfSSL-Fenrir-bot wolfSSL-Fenrir-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fenrir Automated Review — PR #10307

Scan targets checked: wolfcrypt-port-bugs

No new issues found in the changed files. ✅

@dgarske dgarske merged commit c0bc5ef into wolfSSL:master May 5, 2026
480 of 481 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants