DTLS 1.3 client-only minimum: WOLFSSL_DTLS_ONLY + autoconf cascade#10353
Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
DTLS 1.3 client-only minimum: WOLFSSL_DTLS_ONLY + autoconf cascade#10353julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
* configure.ac: --enable-dtls13 auto-enables --enable-dtls and TLS 1.3, with a targeted error if either is explicitly --disabled. * src/internal.c, src/wolfio.c, wolfssl/wolfio.h: new WOLFSSL_DTLS_ONLY compile-time flag elides EmbedReceive / EmbedSend default callbacks and the GetSEQIncrement helper. * wolfcrypt/src/aes.c: add HAVE_AES_DECRYPT to the inv_col_mul definition gate to match its only caller; without it the function is emitted dead under WOLFSSL_AES_DIRECT && NO_AES_DECRYPT and -Werror=unused-function fails the build. * .github/workflows/os-check.yml: matrix entry for a minimal DTLS 1.3 client-only build.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets a minimal DTLS 1.3 “client-only” build configuration by improving autotools option cascading, trimming default stream-IO callbacks under a new WOLFSSL_DTLS_ONLY compile-time flag, and adding CI coverage for that minimal configuration.
Changes:
- Autoconf:
--enable-dtls13now cascades to enable DTLS and TLS 1.3 (unless explicitly disabled) with clearer error messages. WOLFSSL_DTLS_ONLY: compile-time elision of defaultEmbedReceive/EmbedSendcallbacks andGetSEQIncrement()helper.- Build/CI fixes: avoid
-Werror=unused-functionin AES, and add an OS-check matrix entry for the minimal DTLS 1.3 client-only build.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
configure.ac |
Makes --enable-dtls13 cascade-enable DTLS and TLS 1.3 with targeted errors/notices. |
src/internal.c |
Adds WOLFSSL_DTLS_ONLY gates to skip default stream callbacks and TLS sequence helper paths. |
src/wolfio.c |
Removes default stream EmbedReceive/EmbedSend definitions when WOLFSSL_DTLS_ONLY is set. |
wolfssl/wolfio.h |
Removes EmbedReceive/EmbedSend declarations/mappings when WOLFSSL_DTLS_ONLY is set. |
wolfcrypt/src/aes.c |
Gates inv_col_mul() on HAVE_AES_DECRYPT to match its actual usage and avoid unused-function builds failing. |
.github/workflows/os-check.yml |
Adds a CI matrix entry for a minimal DTLS 1.3 client-only configuration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+2715
to
2719
| #ifndef WOLFSSL_DTLS_ONLY | ||
| if (method->version.major == DTLS_MAJOR) | ||
| #endif | ||
| { | ||
| ctx->CBIORecv = EmbedReceiveFrom; |
Comment on lines
+9540
to
9544
| #ifdef WOLFSSL_DTLS_ONLY | ||
| DtlsGetSEQ(ssl, verifyOrder, seq); | ||
| #else | ||
| if (!ssl->options.dtls) { | ||
| GetSEQIncrement(ssl, verifyOrder, seq); |
Comment on lines
+5745
to
+5749
| if test "x$ENABLED_TLS13" != "xyes" | ||
| then | ||
| AC_MSG_NOTICE([DTLSv1.3 is enabled, enabling TLS 1.3]) | ||
| ENABLED_TLS13=yes | ||
| fi |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with a targeted error if either is explicitly --disabled.
compile-time flag elides EmbedReceive / EmbedSend default callbacks
and the GetSEQIncrement helper.
definition gate to match its only caller; without it the function is
emitted dead under WOLFSSL_AES_DIRECT && NO_AES_DECRYPT and
-Werror=unused-function fails the build.
client-only build.