[Renesas RX72N] Fix SP_MATH and SP_MATH_ALL conflict in user_settings.h#10355
Open
miyazakh wants to merge 1 commit intowolfSSL:masterfrom
Open
[Renesas RX72N] Fix SP_MATH and SP_MATH_ALL conflict in user_settings.h#10355miyazakh wants to merge 1 commit intowolfSSL:masterfrom
miyazakh wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Resolves a configuration macro conflict in the Renesas RX72N EnvisionKit e2studio demo user_settings.h that triggers a build-time validation error when both WOLFSSL_SP_MATH and WOLFSSL_SP_MATH_ALL are defined.
Changes:
- Remove
#define WOLFSSL_SP_MATHwhile keeping#define WOLFSSL_SP_MATH_ALLenabled to avoid the mutual-exclusivity error.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a conflict in
user_settings.hwhere both SP_MATH and SP_MATH_ALL were defined.Testing
Run wolfcrypt on the device
Checklist