fix: guard wc_Ed448PublicKeyToDer ed448_export_public call for FIPS<7#10416
Open
jackctj117 wants to merge 1 commit intowolfSSL:masterfrom
Open
fix: guard wc_Ed448PublicKeyToDer ed448_export_public call for FIPS<7#10416jackctj117 wants to merge 1 commit intowolfSSL:masterfrom
jackctj117 wants to merge 1 commit intowolfSSL:masterfrom
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10416
Scan targets checked: wolfcrypt-bugs, wolfcrypt-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Ed448 public-key DER export path in wolfcrypt/src/asn.c to better support older wolfCrypt FIPS v3 builds by conditionally adjusting the constness of the wc_ed448_export_public call to match API differences.
Changes:
- Add a
HAVE_FIPS && FIPS_VERSION3_LT(7,0,0)conditional aroundwc_ed448_export_publicinwc_Ed448PublicKeyToDer. - For FIPS v3 < 7.0.0, cast
keyto non-const when callingwc_ed448_export_public(matching the existing Ed25519 pattern in the same file).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a conditional compilation change to the
wc_Ed448PublicKeyToDerfunction inasn.cto improve compatibility with FIPS builds. Specifically, it adds a preprocessor check to handle the function call towc_ed448_export_publicdifferently based on the FIPS version.Compatibility fix for FIPS builds:
wolfcrypt/src/asn.c, the call towc_ed448_export_publicis now conditionally compiled: for FIPS version 3 less than 7.0.0, thekeyparameter is explicitly cast to non-const, addressing compatibility or API differences in those builds.