IDE/iotsafe: fix memory TLS wrapper and example build#10457
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Revives the IoT-Safe memory-TLS example by hardening the in-memory wolfSSL I/O callbacks and fixing several build/runtime issues in the example configuration and BSP stubs.
Changes:
- Centralizes and hardens in-memory send/recv logic for wolfSSL CBIO callbacks, including partial transfer handling and additional error checking for IoT-Safe enablement.
- Updates example build configuration (feature flags / no-sockets) and BSP headers for correctness.
- Removes a redundant
_sbrk_rthat collides with newer newlib implementations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| IDE/iotsafe/user_settings.h | Adjusts wolfSSL feature defines for the bare-metal example (adds WOLFSSL_NO_SOCK). |
| IDE/iotsafe/memory-tls.c | Refactors CBIO send/recv into helpers, adds error handling for IoT-Safe enablement, and NUL-terminates server-received data before printing. |
| IDE/iotsafe/devices.h | Adds missing <stdint.h> include for fixed-width types. |
| IDE/iotsafe/devices.c | Removes conflicting _sbrk_r implementation to fix linker collision with newlib. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3 tasks
dgarske
approved these changes
May 12, 2026
Member
|
Jenkins retest this please. History lost for PRB master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revived and fixed IoT-Safe example, including:
of-bounds copies.