20260611-AES-XTS-key-half-inequality#10666
Merged
douzzer merged 1 commit intoJun 12, 2026
Merged
Conversation
douzzer
requested review from
SparkiDev,
kaleb-himes,
kareem-wolfssl,
wolfSSL-Bot and
wolfSSL-Fenrir-bot
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10666
Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
kareem-wolfssl
requested changes
Jun 11, 2026
wolfcrypt/src/aes.c: enforce AES-XTS K1!=K2 constraint in wc_AesXtsSetKeyNoInit() unless WC_AES_XTS_ALLOW_DUPLICATE_KEYS and !HAVE_FIPS: tests/api/test_aes.c: add negative tests to test_wc_AesXtsSetKey() for K1==K2; wolfcrypt/test/test.c: fix keys in aes_xts_128_inplace_test() and aes_xts_192_inplace_test() so that K1!=K2, update test vectors, and remove associated !HAVE_FIPS gating; linuxkm/lkcapi_aes_glue.c: synchronize aes_xts_128_test() test of ciphertext stealing in-place with wolfcrypt/test/test.c. wrapper/rust/wolfssl-wolfcrypt/src/aes.rs: synchronize XTS streaming test with wolfcrypt/test/test.c. linuxkm/: refactor self-test sensing with version-gated setup in linuxkm_wc_port.h and refactored gates in lkcapi_glue.c.
douzzer
force-pushed
the
20260611-AES-XTS-key-half-inequality
branch
from
a3b0854 to
0097739
Compare
kareem-wolfssl
approved these changes
Jun 11, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10666
Scan targets checked: linuxkm-bugs, linuxkm-src, wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-rs-src, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Member
|
Jenkins retest this please: "Build 'wolfSSL/PRB-fips-repo-and-harness-test-v3-part2' failed with result: FAILURE" |
SparkiDev
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes for F-3325:
wolfcrypt/src/aes.c: enforce AES-XTS K1!=K2 constraint inwc_AesXtsSetKeyNoInit()unlessWC_AES_XTS_ALLOW_DUPLICATE_KEYSand !HAVE_FIPS:tests/api/test_aes.c: add negative tests totest_wc_AesXtsSetKey()for K1==K2;wolfcrypt/test/test.c: fix keys inaes_xts_128_inplace_test()andaes_xts_192_inplace_test()so that K1!=K2, update test vectors, and remove associated !HAVE_FIPSgating;linuxkm/lkcapi_aes_glue.c: synchronizeaes_xts_128_test()test of ciphertext stealing in-place withwolfcrypt/test/test.c.wrapper/rust/wolfssl-wolfcrypt/src/aes.rs: synchronize XTS streaming test withwolfcrypt/test/test.c.linuxkm/: refactor self-test sensing with version-gated setup inlinuxkm_wc_port.hand refactored gates inlkcapi_glue.c.tested with