Skip to content

settings.h: don't set WOLFSSL_GENSEED_FORTEST.#10672

Open
philljj wants to merge 1 commit into
wolfSSL:masterfrom
philljj:genseed_fortest
Open

settings.h: don't set WOLFSSL_GENSEED_FORTEST.#10672
philljj wants to merge 1 commit into
wolfSSL:masterfrom
philljj:genseed_fortest

Conversation

@philljj

@philljj philljj commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

We should not set WOLFSSL_GENSEED_FORTEST in our settings.h.

It's fine for demo examples, but not in main code.

Fixes F-2623.

@philljj philljj self-assigned this Jun 12, 2026
Copilot AI review requested due to automatic review settings June 12, 2026 01:52
@philljj philljj added the For This Release Release version 5.9.2 label Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the unconditional WOLFSSL_GENSEED_FORTEST define from the main settings.h configuration to avoid enabling deterministic RNG seeding in core builds (keeping such behavior limited to demos/examples or explicit user settings).

Changes:

  • Removed #define WOLFSSL_GENSEED_FORTEST from the FREERTOS_TCP block in wolfssl/wolfcrypt/settings.h.
Comments suppressed due to low confidence (1)

wolfssl/wolfcrypt/settings.h:1734

  • With WOLFSSL_GENSEED_FORTEST removed, the FREERTOS_TCP settings now fall back to the default RNG seeding path in wolfcrypt/src/random.c (POSIX /dev/* + <fcntl.h>/<unistd.h>), which is typically unavailable in FreeRTOS builds. Consider defining NO_DEV_RANDOM here (unless the application overrides it) so FreeRTOS+TCP builds don’t accidentally depend on /dev/random and instead fail fast unless a proper seed source is provided (e.g., crypto callback or custom seed implementation).
    #define NO_WOLFSSL_DIR
    #define NO_WRITEV
    #define TFM_TIMING_RESISTANT
    #define NO_MAIN_DRIVER

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants