Attempt wolfssl_read_bio_file in read_bio even when XFSEEK is available #8703
+5
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins Retest this please |
dgarske
requested changes
May 6, 2025
dgarske
approved these changes
May 6, 2025
|
Retest this please: "Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some changes required for wolfSSL/wolfCLU#178.
wolfSSL_BIO_Read()to account for BIO's created with symlink files that aren't fseek-able (for eg./proc/self/fd/0)wc_CreatePKCS8Key()whenWOLFSSL_NO_ASN_STRICTis defined for cases where an existing PKCS8 key is being created in place in the same BIO via thewolfSSL_d2i_PrivateKey_bio()APIFixes zd#19592
Testing
Testing done with wolfCLU
Checklist