ech get length fix and x509 extension print temporary buffer size #8710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes two issues: one concerning the temporary buffer size used when printing X509 extensions and another adjusting the length calculations in the GetEchConfigsEx function.
- In src/x509.c the temporary buffer size is increased by removing subtraction of indentation and a constant offset.
- In src/ssl.c the logic for calculating the working output length and associated checks has been restructured.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/x509.c | Changed allocation size in X509PrintExtensions to use MAX_WIDTH instead of MAX_WIDTH-4-indent. |
| src/ssl.c | Refactored GetEchConfigsEx to initialize and adjust workingOutputLen based on whether output is provided. |
|
Retest this Jenkins |
SparkiDev
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.