Speculative fix for CodeSonar overflow issue in ssl_certman.c #8715
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
force-pushed
the
ssl-certman-codesonar
branch
from
38ef020 to
1c91f7e
Compare
dgarske
requested changes
Apr 25, 2025
padelsbach
force-pushed
the
ssl-certman-codesonar
branch
from
1c91f7e to
b4d9442
Compare
|
Retest this please: "Found unhandled hudson.remoting.RequestAbortedException exception: java.io.StreamCorruptedException: invalid stream header: 636F7272" |
dgarske
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CodeSonar thinks there is a buffer overrun in
CM_MemRestoreCertCachewhen checkinghdr->version, etc. The length is checked indirectly when comparingcurrent > end.This change provides a more direct check to see if CodeSonar is happy.
Buffer Overrun _ daily _ CodeSonar.pdf
Testing
Awaiting CodeSonar run.
Checklist