Fix an off-by-one buffer error in asn.c. #8724
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to ensure "finsh-start" is less than the size before using it as an index a few lines down.
|
Can one of the admins verify this patch? |
|
Hi @seego5555 , Thank for your this PR. I do not see you setup as a contributor. Typically for a small PR like this we will treat as bug report and then reproduce fix ourselves. Can you tell us more about your project, where you are located and how you discovered this issue? If you would like to keep details private please email support at wolfssl dot com and reference this PR. Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to ensure "finish-start" is less than the size before using it as an index a few lines down.
Description
On line 26156 of asn.c, a check is made that "finish-start" is greater than the size of the buffer and if so, it returns an error. A few lines down the buffer is accessed at index "finish-start", which will write off the end of the buffer if "finish-start" equals the size of the buffer. The fix is to ensure that "finish-start" is less than the buffer size by changing "<" to "<=" on the comparison.