Skip to content

Add support for no malloc with wc_CheckCertSigPubKey #8725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AlexLanzano
Copy link

@AlexLanzano AlexLanzano commented May 1, 2025

Description

  • Add support for WOLFSSL_NO_MALLOC in wc_CheckCertSigPubKey. Fixes ZD 19593
  • Refactor DSA ASN.1 decode in ConfirmSignature.
  • Cleanup indent in types.h.
  • Move struct CertSignCtx to types.h.
  • Move WC_ENABLE_ASYM_KEY_IMPORT and WC_ENABLE_ASYM_KEY_EXPORT to settings.h.

Testing

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev
Copy link
Contributor

retest this please
Hudson error and fips failure

@dgarske
Copy link
Contributor

dgarske commented May 5, 2025

Retest this please

@dgarske dgarske changed the title WIP: No malloc support for wc_CheckCertSigPubKey Add support for no malloc with wc_CheckCertSigPubKey May 6, 2025
Copy link
Contributor

@dgarske dgarske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Customer is happy with this work, but is small typo in asn.c:18418.

@dgarske dgarske force-pushed the no-malloc-support branch from a135d51 to ff3f480 Compare May 6, 2025 18:28
@dgarske dgarske force-pushed the no-malloc-support branch from f52aba4 to c4d6122 Compare May 6, 2025 21:05
@dgarske dgarske self-assigned this May 6, 2025
@dgarske dgarske force-pushed the no-malloc-support branch from c4d6122 to 9616df7 Compare May 6, 2025 21:21
…on-blocking. Refactor DSA ASN.1 decode in ConfirmSignature. Cleanup indent in types.h. Move `struct CertSignCtx` to types.h. Move `WC_ENABLE_ASYM_KEY_IMPORT` and `WC_ENABLE_ASYM_KEY_EXPORT` to settings.h.
@dgarske dgarske force-pushed the no-malloc-support branch from 9616df7 to a1f4717 Compare May 6, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants