Fix for STM32 hash status check logic (also fix NO_AES_192 and NO_AES_256) #8732
+173
−92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Retest this please Cloning the remote Git repository |
… calculation was indicating "not busy" before digest result (DCIS) was finished. This did not show up on most systems because the computation is usually done by the time it reads.
…LD_ logic for `ADH-AES256-GCM-SHA384`.
…he digest calculation complete.
…p12` that uses DES3 and AES-CBC-256.
|
Retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for STM32 Hashing status bit checking logic. Fixes ZD 19783.
The digest calculation was indicating "not busy" before digest result (DCIS) was finished. This did not show up on most systems because the computation is usually done by the time we read the computed digest.
Fixes for
NO_AES_192/NO_AES_256and added test case.Note: Most STM32 AES hardware engines do not support 192-bit.
Fixed bad BUILD_ logic for
ADH-AES256-GCM-SHA384.Testing
Tested on STM32U585 with IAR
Checklist