Fix: Operation security should override top-level#186
Merged
wolfadex merged 5 commits intowolfadex:mainfrom Mar 4, 2025
Merged
Conversation
Contributor
Author
|
I'd suggest adding (The diff failed due to permissions or whatnot, but it looks like it was empty, anyway, in spite of new files being generated -- it is not showing new files, now.) |
wolfadex
approved these changes
Mar 4, 2025
adamdicarlo0
deleted the
adam/paths-security-should-override-global-security
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires wolfadex/elm-open-api#11 (CI currently fails due to this)
In order to allow schema override files to also override (replace) individual operations'
securityvalues, we must special-case theJsonValuemerging logic onkey == "security". This is needed because otherwisesecurity: []in an override will just be merged into, e.g.,security: [{ Token: [] }]in the schema's operation, not changing anything.This also affects how top-level
securityis handled; that may sound weird, but I think it's good/necessary, because it gives the most flexibility to override files. But it is a special case, whereas all other override data are merged with the OAS data.@wolfadex @miniBill What do you think?