[pull] master from livekit:master#908
Merged
Merged
Conversation
* Tweaks tresholds for logging high forwarding latency/jitter. Previous attempt showed skewed jitter (i. e. more than 10x latency), But, no large latency. So, reducing the latency treshold to declare high latency. And also keeping track of lowest/highest per reporting window and logging those along with short term and long term measurements. NOTE: previously short term and long term were separate calls with locks acquired. Now, it is all in one lock. So, it does increase the lock duration a bit, but hopefully not by too much as the welford merge for short term would go over 20 samples (at 50 ms sampling interval and 1 s reporting window). * revert skew factor
* ForwarStats.GetStats needs to be public * prevent deadlock
With no packets flowing through, the stat gets stuck. Flush the pipe if there have been no packets in the report interval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )